why this code dont work ?!

PHP Code:

<? if($lang=='eng'){
if(file_exists("engfiles/".$_GET['pn'].".php"))
 include ("engfiles/".$_GET['pn'].".php");
 else include("engfiles/right.php");
}
elseif($lang=='rus'){
if(file_exists("rusfiles/".$_GET['pn'].".php"))
include ("rusfiles/".$_GET['pn'].".php");
else include("rusfiles/right.php");
}
else{
if(file_exists("files/".$_GET['pn'].".php"))
include ("files/".$_GET['pn'].".php");
else include("files/right.php");
}
?>

Can any one help me ?

a few sugestions :
- use { on all if clause
- put an echo on each if .. and else to see where it stops ..

Another good idea would be to explain what the code does, and what you want it to do - unless there's an obvious syntax error then there's very little chance that we can help without more detail from you.

Personally, I'd probably rewrite your code to use a switch statement on $lang as it would be a bit more readable that way - personal preference though...

I would also suggest that using $_GET['pn'] in that context without validation prior to that may be dangerous, so unless you're already validating to make sure it contains the data you expect it may be a good idea to add that to your code. Difficult to say what validation you should perform without knowing more about the context.

good ideea damian

switch ($lang) {
case 'eng' : $folder='engfiles'; break;
case 'rus' : $folder='rusfiles'; break;
default : $folder='files'; break;
}
if(file_exists($folder."/".$_GET['pn'].".php")){
include ($folder."engfiles/".$_GET['pn'].".php");
} else {
include($folder."/right.php");
}