I'm trying to write to my log file using this code in my class:

PHP Code:

function writeLog($str) {
        $h = fopen($this->logFile, 'a');
        fwrite($h, date("D M j G:i:s T Y") . ' ' . $str . PHP_EOL);
        fclose($h);
} 


It works all well and good, but calling this function writes the string to the log file at least 3 times, every time! I have verified this function is getting called exactly 1 time.

Ex:
$Flickr->writeLog('Generating Image');
Gives me this in my log file:

Thu Jan 15 8:48:59 PST 2009 Generating Image
Thu Jan 15 8:49:01 PST 2009 Generating Image
Thu Jan 15 8:49:01 PST 2009 Generating Image

Anyone have any ideas why this is happening?

PHP Code:

function writeLog($str) {
        file_put_contents(file_get_contents($this->logFile).date("D M j G:i:s T Y") . ' ' . $str . PHP_EOL, $this->logFile);
} 


Is a bit better coding wise.

However, i think something else is writing to the log as the timestamp is changing.
8:48:59
8:49:01

Yeah that should probably work, but both file_get_contents and file_put_contents open and close the file, leading to some unnecessary processing time. I'll implement it for now till I can figure out what's going on here

Originally Posted by rogem002

PHP Code:

function writeLog($str) {
        file_put_contents(file_get_contents($this->logFile).date("D M j G:i:s T Y") . ' ' . $str . PHP_EOL, $this->logFile);
} 


Is a bit better coding wise.

Performances wise, it's not recommended.
What this code does is to read the complete file, append a line and overwrite the original file with the full content.

On a small log, ok.
But when your log reaches a certain size, it's overkill.

The fopen() in append mode is much more logical and put less stress over the server.