Hey guys.
I got this code:

<?php
/*--------------------------------------------------------------------
Settings File
--------------------------------------------------------------------*/
// DB Settings
define("MySQL_Server","localhost"); //MySQL Server
define("MySQL_Username","root"); //MySQL Username
define("MySQL_Password",""); //MySQL Password

define("MySQL_DB_Name","yeadim_d0b") //MySQL DB Name

/*--------------------------------------------------------------------
Global Functions
--------------------------------------------------------------------*/
function DBConnect()‎
{
$MySQL_Link = mysql_connect(MySQL_Server,MySQL_Username,MySQL_Password) or die(""); //MySQL Connection

//Connection check
if ($MySQL_Link==false) {
return false;
}
else {
if (mysql_select_db(MySQL_DB_Name,$MySQL_Link))
{return true;}
else
{return false;}
}
?>‎

The error:

Parse error: parse error in C:\wamp\www\Yeadim\Sets.php on line 15

and the line with the error is

function DBConnect()‎

So... what the hell?

did you pass in your arguments?

Just the usual errant semi-colon

define("MySQL_DB_Name","yeadim_d0b"); //MySQL DB Name

Chris nailed it again.

The line number for the error message is frequently one less that what is displayed in the error message because the error occurs when PHP can not parse the line properly because of a missed semiclon on the line above.

Originally Posted by chrishirst

Just the usual errant semi-colon

define("MySQL_DB_Name","yeadim_d0b"); //MySQL DB Name

ha ha thanx, now I got another problem:

 Parse error:  parse error, expecting `'{'' in C:\wamp\www\Yeadim\Sets.php on line 15

the same code + the semi-colon fix.
line 15 is "function D‎BConnect()‎".

Thanks, Noam

PHP Code:

<?php
/*--------------------------------------------------------------------
Settings File
--------------------------------------------------------------------*/
// DB Settings
define("MySQL_Server","localhost"); //MySQL Server
define("MySQL_Username","root"); //MySQL Username
define("MySQL_Password",""); //MySQL Password

define("MySQL_DB_Name","yeadim_d0b"); //MySQL DB Name

/*--------------------------------------------------------------------
Global Functions
--------------------------------------------------------------------*/
function DBConnect()&#8206;
{
$MySQL_Link = mysql_connect(MySQL_Server,MySQL_Username,MySQL_Password) or die(""); //MySQL Connection

//Connection check
if ($MySQL_Link==false) {
return false;
}
else {
if (mysql_select_db(MySQL_DB_Name,$MySQL_Link))
{return true;}
else
{return false;}
}
?>

That's a copy and paste of your code from above (with the semi-colon) notice any thing odd in line 15?

now it's the first time I see it!
I wrote the file in ANSI. After turning it to utf8, the document had strange  (wtf?) in few places. I've deleted it and it works just fine.
What is it?

Depends on what editor you used, some will add formatting/wordprocessor control characters.

Originally Posted by chrishirst

Depends on what editor you used, some will add formatting/wordprocessor control characters.

bloody notepad...

Curious, can't say I've ever seen notepad add characters.

well, another problem.
I've tweaked my code a little bit (some of it was wrong as you noticed).
The problem: infinite loop. The rest of the code is fine...
BTW: the die(...) errors are in Hebrew.
The program prints 111111111111111111111... (the content of "Acid").

<?php
/*--------------------------------------------------------------------
Settings File
--------------------------------------------------------------------*/
// DB Settings
define("MySQL_Server","localhost"); //MySQL Server
define("MySQL_Username","root"); //MySQL Username
define("MySQL_Password",""); //MySQL Password

define("MySQL_DB_Name","blabla"); //MySQL DB Name

/*--------------------------------------------------------------------
Global Functions
--------------------------------------------------------------------*/

function DBConnect($Q)
{
$MySQL_Link = mysql_connect(MySQL_Server, MySQL_Username, MySQL_Password) or die("שגיאה"); //MySQL Connection
//Connection check
$MySQL_DB_Selection = mysql_select_db(MySQL_DB_Name, $MySQL_Link) or die("שגיאה 2");
//Query
$MySQL_Q=mysql_query($Q,$MySQL_Link) or die("שגיאה 3");
Global $MySQL_Row;
$MySQL_Row=mysql_fetch_array($MySQL_Q) or die("שגיאה 4");
}
DBConnect("select * from acats;");

while ($MySQL_Row)
{
echo $MySQL_Row['Acid'];

}


function DBClose()
{
mysql_close($MySQL_Link);
}
?>

errors are in Hebrew.

That probably explains the strange characters then

seperate the function definitions from the working codebase.

GET RID of the global variable, they are rarely a good idea, and make DBConnect return a value to the function call.

Ensure that the function DOES return false on any errors.