Im trying to create a simple script that will make a <p> tag appear, but in the Firefox console I get the error

document.form1.visible has no properties

here is the code im using:

CSS:

.visible {
visibility:hidden;}

HTML:

<p class="visible" id="visible">
        <label for="other" class="labelDef">Other</label>
        <input type="text" name="other" id="other" />
        <label for="button"></label>
        <br class="clear" />
      </p>

javascript:

function appear()
    {
        document.form1.visible.style.visibility="visible";
    }

Any ideas what Im doing wrong? I did originally set it so that the html name could be passed as an argument, as I wanted to be able to re use the script for other elements. But the script was causing me so much hassle its wound its way down to what's above!

First you don't need both the class and the id. In general it's one or the other. In this case I'd suggest using the id.

Try this for the funtion

function appear(){
  var vis = document.getElementByID("visible");
  vis.style.visibility = "visible"
}

I don't see where in your code you're calling the function, but I'll assume you're doing that somewhere else not shown here. If not you do need to call the function at some point.

Thanks its working now! I was sure I had something similiar to that originially aswell!

Hmmm Ive now tried altering the code to this:

HTML:

onClick="appear(visible)"

JS:

function appear(element)
    {
        vis = document.getElementById(element);
        vis.style.visibility = "visible";
    }

But now it wont work??

I think you might need to wrap quotes around 'visible' when you pass it to the function in the onClick. Not 100% sure, but try

onclick="appear('visible')"

that's correct, without quotes "visible" would be taken as a variable name and the value of that will be passed to the function.

Thanks, I used apostrophe's and it worked. Whats really annoying me is that I tried that last night and it still wouldnt work! I tried deleting my browser history to make sure that the page would refresh properly and it still made no difference!

I know it sounds like Im making it up, but Im not lol.

I don't think you're making it up. Odd things like that have happened to me too. You'd swear you tried something one way and it didn't work and later it does work.

I think it's usually us thinking we tried something when we really missed one part of it. Either that or it's gremlins.