Simple function with variables issue

**SillyWilly** · 05:43 AM

I don't know why this isn't working. I just can't figure it out. Hopefully somebody can help me.

Basically I'm trying to change the source of 48 images onclick so I have to use variables in the getElementById, but I can't get it to work with variables.

Code:

<script type="text/javascript">

var galnum=02
var i=0

function picschange()
{
i+=1;
window.document.getElementById('imgid'+i).src='Pics/Gallery'+galnum+'/Picture'+i+'.jpg';
if (i < 2) {picschange()}
}

</script>

Code:

<img id="imgid1" src="Pics/Gallery01/Picture1.jpg">
<img id="imgid2" src="Pics/Gallery01/Picture1.jpg">

<a onclick="picschange()">CLICK</a>

**chrishirst** · 02-17-2008, 04:24 AM

and the error you are getting is?

do we get a url to see what is not happening and of course could get the required images should the need to actually test it arise?

**SillyWilly** · 05:44 AM

Ok I found the error.

I decided to document.write the variables to see what would show up and I noticed that the galnum variable was 2 and not 02 you can't have an integer 0 in front or it'll just ignore it.

So I have the problem fixed; I'll just have to change the different galnum variables to strings.

Since I figured out the problem I can now use my for loop for this instead which is faster.