Reply
Help!! Business case for good code?
Old 08-06-2007, 10:55 PM Help!! Business case for good code?
ForrestCroce's Avatar
Half Man, Half Amazing

Posts: 3,024
Name: Forrest Croce
Location: Seattle, WA
I've started a full-time gig as a "web developer," and a jack of all trades. There's another developer other than me, devoted to SQL, and a third, a consultant. Our main priority at this point is dealing with about 900 asp 3.0 pages, deleting the ones we don't need and rewriting the ones that have value in asp.net 2.0 ... and while I'm getting up to speed mode, that's what I've been focused on.

The first page is a form with a textbox / input field and a button. This is nested in three tables for some reason. So the natural thing is a div styled to look like the crazy page. After the first code review, I get an email: "Do not - I repeat, do not - get obsessed about tabling. More time is wasted on this useless topic than almost anything else I've seen in markup land."

Our policy is to validate the markup to html 4 or transitional. I suggested using strict because the company sells a product through their site, and it should work on a blackberry. The answer is that strict is impossible to achieve. And there have been a lot of other really absurd decisions and priorities made by a higher level of management. Don't use css inheritance. Delete pages, move the rest into different folder structures. And I was actually told not to take the time to use 301s in the cases where we're redirecting at all, since a 302 is one line of code instead of three or four ... if you don't just write a method in the base class.

Now, I have stock options in the company, so it's in my interest for them to do well. For more reasons than just having a continued paycheck; I'm starting to wonder if accepting this offer was the right thing to do. Anyway, my ego isn't tied up in this, but I have a really hard time doing important things the wrong way. I've been called "argumentative" in the past because in a case like this, I can't let the issue drop until whoever is making the decision at least understands the implications. And people think they're making the best choices, pounding a mediocre new site out quickly.

So can anybody give me some advice on crafting an argument from a business standpoint to doing things the right way? "My ethics prevent me from ripping you off" doesn't really work in this context, and apocalyptic scare tactics about things will crash isn't appropriate either. So how do I argue that using the proper tags the way they were meant to be used, taking advantage of css like it's 2007, and not killing the search position for all the pages we've had for years is a good business practice? The last one is easier; the company has been profitable despite all this, but how do I make a case for good markup?
ForrestCroce is offline
Reply With Quote
View Public Profile Visit ForrestCroce's homepage!
 
When You Register, These Ads Go Away!
     
Old 08-06-2007, 11:29 PM Re: Help!! Business case for good code?
ADAM Web Design's Avatar
Canadastaninianite

Posts: 5,945
Name: Adam for web page design, not program
Location: Toronto, Ontario, Canada
One word...future-proofing. What happens when all the old code doesn't work on new browsers because new browsers render the old code obsolete?

Tabled layouts load more slowly, since they need to make two passes (one for the table and one for the content).

Tableless layouts can allow for code order rearrangement. Tabled can't.

Tableless layouts reduce code.

Those are three standalone reasons right there that should justify it. I'm sure others will suggest more, but that by itself is enough.

Mind you, what you're in sounds like the symptom of a much deeper issue...you've got yourself involved with a company suffereing from a serious case of Cranial Rectal Syndrome, and one that the regular amounts of Vaseline and a clue won't cure.

The good news is that these idiots have given you the one thing that renders you almost immune to any arguing: you're an owner. As long as you have stock, you have ownership interest and can make ownership-level decisions. This sounds like an ownership decision to me that you should be making, boss man.
ADAM Web Design is offline
Reply With Quote
View Public Profile Visit ADAM Web Design's homepage!
 
Old 08-07-2007, 12:02 AM Re: Help!! Business case for good code?
ForrestCroce's Avatar
Half Man, Half Amazing

Posts: 3,024
Name: Forrest Croce
Location: Seattle, WA
Quote:
Originally Posted by ADAM Web Design View Post
Tableless layouts reduce code.
Again, and sorry, I'm in a bad mood thinking about this, but we have a page with a pretty friggen simple form. A text box and button; where this needed three nested tables is beyond me. The one-div-plus-styling version is something a temp could edit down the line, without worrying about loosing a particular td/tr tag, or a set, or breaking colspan and rowspan.

At first the orders were to keep the tables to save time rewriting everything, but since we're doing that anyway, splitting asp into "webforms" and "code-behind" it's faster to type less. Pointing this out, it came up that uniformity of code is important to us. Someone is just married to tables for regular layout.

Quote:
Originally Posted by ADAM Web Design View Post
Mind you, what you're in sounds like the symptom of a much deeper issue...you've got yourself involved with a company suffereing from a serious case of Cranial Rectal Syndrome, and one that the regular amounts of Vaseline and a clue won't cure.
Yeah, and the saving grace is it's really one individual with undue influence. And this is my second week, so it's kind of presumptive to be rocking the boat. I tend to choose my battles anyway, and not bring things up unless they're important and really do need to be dealt with.

On that note, would it be fair to say removing 90 % of the pages on the site, all of them with navigation links back into the rest of the site, just can't be done without redirects from the 404 page logic?

Quote:
Originally Posted by ADAM Web Design View Post
The good news is that these idiots have given you the one thing that renders you almost immune to any arguing: you're an owner. As long as you have stock, you have ownership interest and can make ownership-level decisions. This sounds like an ownership decision to me that you should be making, boss man.
I could have stayed at Getty... It's actually a really good job, at a catalog company that's been profitable for 20 years. They've had an old asp site forever, and we're rebuilding it from the ground up. Which means we can do things the right way, and poise for the future ... but that means we have to take the past into account, and we have to look at the present as an opportunity instead of a burden.
ForrestCroce is offline
Reply With Quote
View Public Profile Visit ForrestCroce's homepage!
 
Old 08-07-2007, 01:02 AM Re: Help!! Business case for good code?
ADAM Web Design's Avatar
Canadastaninianite

Posts: 5,945
Name: Adam for web page design, not program
Location: Toronto, Ontario, Canada
Quote:
On that note, would it be fair to say removing 90 % of the pages on the site, all of them with navigation links back into the rest of the site, just can't be done without redirects from the 404 page logic?
It might not even be all that doable with the redirects. Why not just replace them with pages containing nothing but the redirect code to be safe?
Quote:
They've had an old asp site forever, and we're rebuilding it from the ground up.
That might be part of the angle you take...if the site were working all that well, it wouldn't need a ground up rebuild. Code is a factor...all code.
ADAM Web Design is offline
Reply With Quote
View Public Profile Visit ADAM Web Design's homepage!
 
Old 08-07-2007, 01:21 AM Re: Help!! Business case for good code?
ForrestCroce's Avatar
Half Man, Half Amazing

Posts: 3,024
Name: Forrest Croce
Location: Seattle, WA
I'm thinking it will still be pretty painful with redirects. But as long as we send down 301 status codes, does it matter whether it's from shelled out asp pages, or the 404 page? Or does that automatically send down a 404 response when it starts to process? I might have to use http handlers or isapi filters.

They've made the decision that all asp pages must go, either to the trash or to be resurrected in .net. There's a lot of faulty logic behind that, and people aren't realizing that adding an x to the end of your extension changes the URL. It's not the fact a lot of internal pages have better PR than any in my site, it's that suddenly all these links from the navigation that have existed for years have vanished.

Ultimately I'd rather have them using .net down the line, so it's not worth fighting over like using tables to show lists of links, so this will go through. And people are going to squeal like a pig regardless, but it seems like we need to do what we can to need less, uh, never mind.
ForrestCroce is offline
Reply With Quote
View Public Profile Visit ForrestCroce's homepage!
 
Old 08-07-2007, 01:26 AM Re: Help!! Business case for good code?
vangogh's Avatar
Post Impressionist

Latest Blog Post:
A Focused Blog Is A Happy Blog
Posts: 8,663
Name: Steven Bradley
Location: Boulder, Colorado
Forrest show them this article, specifically the section Clean Code Matters. The advice comes from someone at Google who hinted that clean code might get more of your pages indexed.

Other business arguments you can try are to let them know that cleaning up the code will reduce download times keeping more people on the site.

I would think the need to display well on a Blackberry would have been enough, but it doesn't sound like it.

You can also tell them how it will make maintenance easier and less expensive in the future.

If you plan on working for this company for awhile you don't have to try to make sweeping changes all at once. Make a few small changes here or there and in time you'll have changed over the whole site.
__________________
l Search Engine Friendly Web Design | Van SEO Design
l Tips On Marketing, SEO, Design, and Development | TheVanBlog
l Custom WordPress Themes
| Small Business Forum
vangogh is offline
Reply With Quote
View Public Profile Visit vangogh's homepage!
 
Old 08-07-2007, 01:51 AM Re: Help!! Business case for good code?
ForrestCroce's Avatar
Half Man, Half Amazing

Posts: 3,024
Name: Forrest Croce
Location: Seattle, WA
Quote:
Originally Posted by vangogh View Post
Other business arguments you can try are to let them know that cleaning up the code will reduce download times keeping more people on the site.
I think I'm going to bring this up tomorrow. Browsers will also render valid code more quickly. Text markup is a lot slower than any kind of binary format, like SQL, so obviously less of it, like one div versus three nested tables with lots of rows and columns, means less CPU cycles to render the markup.

But ... the other question is why on Earth would anyone want to go and do it the wrong way?
ForrestCroce is offline
Reply With Quote
View Public Profile Visit ForrestCroce's homepage!
 
Old 08-07-2007, 03:19 AM Re: Help!! Business case for good code?
Extreme Talker

Posts: 235
Location: United States
Quote:
the company has been profitable despite all this, but how do I make a case for good markup?
The company can still be profitable, because the world doesn't end if you use tables for layout.

Quote:
And people think they're making the best choices, pounding a mediocre new site out quickly.
Quote:
But ... the other question is why on Earth would anyone want to go and do it the wrong way?
For web mark-up, I take usability and development speed over rendering speed and time spent fixing CSS browser bugs. I would take a table layout that takes a fraction of the time to create and over a complete CSS design, even if I know I might have to recode the site in 2009. When IE6 and Safari 2 have a much smaller usage rate, then I will change my habits.

I am not against CSS layouts, but there are times where trade offs have to be made. (e.g. I use CSS layouts for personal projects, and table layouts at my work.)
__________________
The interlocking pieces of web development: usability, performance, accessibility, and standards.
frost is offline
Reply With Quote
View Public Profile
 
Old 08-07-2007, 05:27 AM Re: Help!! Business case for good code?
vkw91's Avatar
Ultra Talker

Latest Blog Post:
Good Web Design Guide - part 1
Posts: 290
Name: Vicky
Location: Wales
Quote:
Originally Posted by frost View Post
The company can still be profitable, because the world doesn't end if you use tables for layout.
I can't be profitable using tables, i am absolutly pants at using them! (which as a good thing as i'm no even tempted by them)

Forrest, i think you need to clear the air with the people you work with asap otherwise both yourself and them are going to become more bitter with eachother and less open to comprimise. It obvoiusly sounds like they are blind to the modern way things work.
__________________
Portfolio: www.vkw91.co.uk
Techno Pup: www.technopup.co.uk


Last edited by vkw91 : 08-07-2007 at 05:30 AM. Reason: typo
vkw91 is offline
Reply With Quote
View Public Profile Visit vkw91's homepage!
 
Old 08-07-2007, 01:29 PM Re: Help!! Business case for good code?
Learning Newbie's Avatar
Moderator

Latest Blog Post:
What’s He Looking At?
Posts: 4,983
Name: John Alexander
Quote:
Originally Posted by frost View Post
For web mark-up, I take usability and development speed over rendering speed and time spent fixing CSS browser bugs. I would take a table layout that takes a fraction of the time to create and over a complete CSS design, even if I know I might have to recode the site in 2009. When IE6 and Safari 2 have a much smaller usage rate, then I will change my habits.
Code:
<tablecellSpacing="2" cellPadding="0" width="100%" border="0">
<tbody>
<tr>
<td>
SOME TEXT HERE
</td>
</tr>
</tbody>
</table>
Code:
<div>
SOME TEXT HERE
</div>
Which method do you think offers better development speed?
__________________
4 ways to improve the lives of the "bottom billion"

"HEY YOU KIDS GET OFF MY LAWN!" -John McCain
Learning Newbie is offline
Reply With Quote
View Public Profile
 
Old 08-07-2007, 01:31 PM Re: Help!! Business case for good code?
Learning Newbie's Avatar
Moderator

Latest Blog Post:
What’s He Looking At?
Posts: 4,983
Name: John Alexander
Quote:
Originally Posted by ForrestCroce View Post
"Do not - I repeat, do not - get obsessed about tabling. More time is wasted on this useless topic than almost anything else I've seen in markup land."
This is frankly the most ignorant thing I've heard in a long time. I agree the world doesn't end when you use a table, but using the right markup elements is about as useless in markup as, I dunno, a parachute is to a sky diver.
__________________
4 ways to improve the lives of the "bottom billion"

"HEY YOU KIDS GET OFF MY LAWN!" -John McCain
Learning Newbie is offline
Reply With Quote
View Public Profile
 
Old 08-07-2007, 02:16 PM Re: Help!! Business case for good code?
LadynRed's Avatar
Super Moderator

Posts: 6,400
Location: Tennessee
Hey Forrest, you might want to peruse thru this post from 456BereaStreet and the resources he has linked there:
It's titled, appropriately enough - business case for web standards

http://www.456bereastreet.com/archiv...tandards_wiki/
You might also check out the "Why Tables for Layout is Stupid" Presentation: http://www.hotdesign.com/seybold/everything.html

Despite it's title, it does have excellent arguments and solutions as to WHY table-less is better from a business standpoint.

Just found another article ala Jeff Zeldman: http://www.businessweek.com/innovate...086_670396.htm
__________________
Web Goddess & Web Standards Evangelist :) - Tables Be Gone !!
"Using or working with IE is like having to wear a 1970's polyester suit with pantyhose and a girdle, to work everyday"
Carolina Corvette Club

Last edited by LadynRed : 08-07-2007 at 02:18 PM.
LadynRed is offline
Reply With Quote
View Public Profile
 
Old 08-07-2007, 03:58 PM Re: Help!! Business case for good code?
Learning Newbie's Avatar
Moderator

Latest Blog Post:
What’s He Looking At?
Posts: 4,983
Name: John Alexander