That probably depends on the size of the site and how much it will earn. Personally, I think if you're making a web site, an up front flat fee is always best, whatever the sort of site it is. Percentages get complicated, particularly once it starts involving tax and then updates to the site and redesigns