Hello,

I found the code for bubble sort in C++.
With the code below the print screen will be:
23
8
7
6
6
5
2
2
1

Is it possible that sorts the numbers so the print screen will show all changes. In example:

9,6,5,23,2,6,2,7,1,8
9,6,23,5,2,6,2,7,1,8
....
....
....
23,9,8,7,6,6,5,2,2,1


Thanking in advance

#include <stdio.h>
#include <iostream.h>

void bubbleSort(int *array,int length)//Bubble sort function 
{
    int i,j;
    for(i=0;i<10;i++)
    {
        for(j=0;j<i;j++)
        {
            if(array[i]>array[j])
            {
                int temp=array[i]; //swap 
                array[i]=array[j];
                array[j]=temp;
            }

        }

    }

}

void printElements(int *array,int length) //print array elements
{
    int i=0;
    for(i=0;i<10;i++)
        cout<<array[i]<<endl;
}


void main()
{

    int a[]={9,6,5,23,2,6,2,7,1,8};   // array to sort 
    bubbleSort(a,10);                 //call to bubble sort  
    printElements(a,10);               // print elements
}

Two changes you would need to make.

1) Change your printElements function to display all of the items on the same line.
Change:

void printElements(int *array,int length) //print array elements
{
    int i=0;
    for(i=0;i<10;i++)
        cout<<array[i]<<endl;
}

to:

void printElements(int *array,int length) //print array elements
{
    int i=0;
    for(i=0;i<10;i++)
        cout<<array[i]<<", ";
    cout << endl;
}

2) Call printElements after you do the swap code in the bubbleSort function.

Change:

            if(array[i]>array[j])
            {
                int temp=array[i]; //swap 
                array[i]=array[j];
                array[j]=temp;
            }

to:

            if(array[i]>array[j])
            {
                int temp=array[i]; //swap 
                array[i]=array[j];
                array[j]=temp;

                printElements(array, length);
            }

All of that's off the top of my head, so no guarantees as to the correctness of code, but the ideas should be sound. By the way, you're passing in a length parameter to both printElements and bubbleSort, but have '10' hardcoded in your for loops: I'm guessing you really want to change that to the length parameter.

Hope that helps...

Just a suggestion, even though BubbleSort is the easiest type of sorting, it's also the slowest, really slow. I suggest you go on Wikipedia and look through the many sorting algorithms there are (i.e. Shear sort) along with the pseudocode, which can be easily translated to c++

Originally Posted by ryogo

Just a suggestion, even though BubbleSort is the easiest type of sorting, it's also the slowest, really slow. I suggest you go on Wikipedia and look through the many sorting algorithms there are (i.e. Shear sort) along with the pseudocode, which can be easily translated to c++

If you're just sorting a small array or something like that the cost of implementing a more advanced algorithm such as merge sort or a binary insertion sort would be too high. You would waste time to shave miliseconds off your run time and you might actually slow it down because of contruction time. But if you're going to be sorting a huge database or something consider a different method.