Pop-up windows not working

**brit** · 10-10-2003, 08:23 AM

I want to implement a pop-windows into the following script, but it doesnt work. Does anyone know what part of coding is wrong; it works without pop windows, just not when I have them in.

Heres the script;

<head>
<p><br>
<style type="text/css">

</style>
</head>

<body><script language="JavaScript1.2">

/*
Cross browser Marquee II- © Dynamic Drive (www.dynamicdrive.com)
For full source code, 100's more DHTML scripts, and TOS, visit http://www.dynamicdrive.com
Credit MUST stay intact
*/

//Specify the marquee's width (in pixels)
var marqueewidth="640px"
//Specify the marquee's height
var marqueeheight="175px"
//Specify the marquee's marquee speed (larger is faster 1-10)
var marqueespeed=1
//Pause marquee onMousever (0=no. 1=yes)?
var pauseit=1

//Specify the marquee's content
//Keep all content on ONE line, and backslash any single quotations (ie: that's great):

var marqueecontent='<font face="Verdana"color="#FF99CC"><p><br><p><br><p><br >text,etc...<a href=" http://www.yahoo.com" onClick="MyWindow=window.open('http://www.yahoo.com','MyWindow','toolbar=yes,location=ye s,directories=yes,status=yes,menubar=yes,scrollbar s=yes,resizable=yes,width=600,height=300'); return false;">yahoo</a></font>'

Thanks!!

**brit** · 10-10-2003, 08:26 AM

Btw, when in place, I have made sure content is all on one line, even though it doesnt show like that here, so its not that either...

**ACJavascript** · 10-12-2003, 12:47 PM

If you look at your code you well see when you call the window.open function it seperates the attributes with a '

And you start your variable that holds all this information with a '.

THats probably the error. What I suggest is make a fuction seperate of the var marquee content.

and just call it. Like onClick="gothere()"

function gothere(){

window.open ect...

**scottfree** · 10-14-2003, 04:36 AM

It is also not logical to have the link in the href="..." as the address is opened in the new window and in the main window. To keep the current page in the main window without reloading use, href="#".
Here is what I usually use:
<a href=\"#\" onClick=\"javascript:window.open('/images/pic2.jpg','pic','width=525,height=700,left=10,top= 10,scrollbars,resize')\">

Try to use the \ before the double quotes as these need to be commented out sometimes.
Or used as a function:

function OPENWIN(Target2)
{
var Target;
Target = window.open("/images/"+Target2, "Target", "width=450,height=650,left=100,top=0,scrollbar s=1, resizable=1");
Target.window.focus();
}
The Target2 in the parameter list will be the image filename.
Hopefully this helps you.

**brit** · 10-15-2003, 06:41 AM

Thanks!!