I have this upload script I'm using and I'd like to add some code that would allow me to determine what size of files will be allowed to be uploaded.

Can you help me with this?
Thanks.

<%@ Language=VBScript %>
<% 
option explicit 
Response.Expires = -1
Server.ScriptTimeout = 600
%>
<!-- #include file="aspupload.asp" -->
<%


' ****************************************************
' Change the value of the variable below to the pathname
' of a directory with write permissions, for example "C:\Inetpub\wwwroot"
  Dim uploadsDirVar
  uploadsDirVar = "d:\inetpub\webmailasp\database\tempUploads" 
' ****************************************************



function OutputForm()
%>
    <form name="frmSend" method="POST" enctype="multipart/form-data" action="uploadTester.asp" onSubmit="return onSubmitForm();">
	<B>File names:</B><br>
    File 1: <input name="attach1" type="file" size=35><br>
    File 2: <input name="attach2" type="file" size=35><br>
    File 3: <input name="attach3" type="file" size=35><br>
    File 4: <input name="attach4" type="file" size=35><br>
    <br> 
	<!-- These input elements are obviously optional and just included here for demonstration purposes -->
	<B>Additional fields (demo):</B><br>
	Enter a number: <input type="text" name="enter_a_number"><br>
    Checkbox values: <input type="checkbox" value="1" name="checkbox_values">-1 <input type="checkbox" value="2" name="checkbox_values">-2<br>
	<!-- End of additional elements -->
    <input style="margin-top:4" type=submit value="Upload">
    </form>
<%
end function

function TestEnvironment()
    Dim fso, fileName, testFile, streamTest
    TestEnvironment = ""
    Set fso = Server.CreateObject("Scripting.FileSystemObject")
    if not fso.FolderExists(uploadsDirVar) then
        TestEnvironment = "<B>Folder " & uploadsDirVar & " does not exist.</B><br>The value of your uploadsDirVar is incorrect. Open uploadTester.asp in an editor and change the value of uploadsDirVar to the pathname of a directory with write permissions."
        exit function
    end if
    fileName = uploadsDirVar & "\test.txt"
    on error resume next
    Set testFile = fso.CreateTextFile(fileName, true)
    If Err.Number<>0 then
        TestEnvironment = "<B>Folder " & uploadsDirVar & " does not have write permissions.</B><br>The value of your uploadsDirVar is incorrect. Open uploadTester.asp in an editor and change the value of uploadsDirVar to the pathname of a directory with write permissions."
        exit function
    end if
    Err.Clear
    testFile.Close
    fso.DeleteFile(fileName)
    If Err.Number<>0 then
        TestEnvironment = "<B>Folder " & uploadsDirVar & " does not have delete permissions</B>, although it does have write permissions.<br>Change the permissions for IUSR_<I>computername</I> on this folder."
        exit function
    end if
    Err.Clear
    Set streamTest = Server.CreateObject("ADODB.Stream")
    If Err.Number<>0 then
        TestEnvironment = "<B>The ADODB object <I>Stream</I> is not available in your server.</B><br>Check the Requirements page for information about upgrading your ADODB libraries."
        exit function
    end if
    Set streamTest = Nothing
end function

function SaveFiles
    Dim Upload, fileName, fileSize, ks, i, fileKey

    Set Upload = New FreeASPUpload
    Upload.Save(uploadsDirVar)

	' If something fails inside the script, but the exception is handled
	If Err.Number<>0 then Exit function

    SaveFiles = ""
    ks = Upload.UploadedFiles.keys
    if (UBound(ks) <> -1) then
        SaveFiles = "<B>Files uploaded:</B> "
        for each fileKey in Upload.UploadedFiles.keys
            SaveFiles = SaveFiles & Upload.UploadedFiles(fileKey).FileName & " (" & Upload.UploadedFiles(fileKey).Length & "B) "
        next
    else
        SaveFiles = "The file name specified in the upload form does not correspond to a valid file in the system."
    end if
	SaveFiles = SaveFiles & "<br>Enter a number = " & Upload.Form("enter_a_number") & "<br>"
	SaveFiles = SaveFiles & "Checkbox values = " & Upload.Form("checkbox_values") & "<br>"
end function
%>

<HTML>
<HEAD>
<TITLE>ASP Upload</TITLE>
<style>
BODY {background-color: white;font-family:arial; font-size:12}
</style>
<script>
function onSubmitForm() {
    var formDOMObj = document.frmSend;
    if (formDOMObj.attach1.value == "" && formDOMObj.attach2.value == "" && formDOMObj.attach3.value == "" && formDOMObj.attach4.value == "" )
        alert("Please press the browse button and pick a file.")
    else
        return true;
    return false;
}
</script>

</HEAD>

<BODY>

<br><br>
<div style="border-bottom: #A91905 2px solid;font-size:16">Upload files to your server</div>
<%
Dim diagnostics
if Request.ServerVariables("REQUEST_METHOD") <> "POST" then
    diagnostics = TestEnvironment()
    if diagnostics<>"" then
        response.write "<div style=""margin-left:20; margin-top:30; margin-right:30; margin-bottom:30;"">"
        response.write diagnostics
        response.write "<p>After you correct this problem, reload the page."
        response.write "</div>"
    else
        response.write "<div style=""margin-left:150"">"
        OutputForm()
        response.write "</div>"
    end if
else
    response.write "<div style=""margin-left:150"">"
    OutputForm()
    response.write SaveFiles()
    response.write "<br><br></div>"
end if

%>
<br><br>

</BODY>
</HTML>

ASP is a server side operation, so the file has to be uploaded before you can determine the file size

The upload class should encapsulate a method for determining the uploaded files size, so you use this to decide whether to save the file or reject it.
The file parameters look to be in an array (according to the code you posted) so at a guess,

if Upload.UploadedFiles(LoopVar).FileSize < MaxFileSize then
' save this file
else
' set an error message
end if

Thank you for your reply.

That sounds about right.

I'm not well versed in asp so can I please ask you:

Where would this code fit into the code that I posted?

In place of Max file size I'd put the actual maximum file size I choose, correct?

Where would I put an error message, in the code?
It would send the message to the upload page?
Thanks again.

MaxFileSize would be a variable that you dimension and set the value of.

Assuming the upload class you are using is this one, to do the file size checking will need another public property declaration to return the file length adding to the class, or write a bit of code to check the file size in the save function.

The error message would be returned by the SaveFiles() function.

Thank you for your reply.

Yes, that is the upload class I am using.
Is this the right forum to ask for "a bit of code to check the file size in the save function"?

Can I find someone here to add it to the code I've already posted in the beginning of this thread?

Thanks again.

Not a problem.

file freeASPUpload.asp add this line into the private variable declaration block

	private m_lMaxFileSize

and

	public property let MaxFileSize(ByVal Val)
		m_lMaxFileSize = Val
	end property
	
	public property get MaxFileSize()
		MaxFileSize = m_lMaxFileSize
	end property

this goes in property declarations (after Class_Terminate() )

This code has to replace the existing Sub Save()

	Public Sub Save(path)
		Dim streamFile, fileItem

		if Right(path, 1) <> "\" then path = path & "\"

		if not uploadedYet then Upload

		For Each fileItem In UploadedFiles.Items
		if fileItem.Length < m_lMaxFileSize then
			Set streamFile = Server.CreateObject("ADODB.Stream")
			streamFile.Type = 1
			streamFile.Open
			StreamRequest.Position=fileItem.Start
			StreamRequest.CopyTo streamFile, fileItem.Length
			streamFile.SaveToFile path & fileItem.FileName, 2
			streamFile.close
			Set streamFile = Nothing
			fileItem.Path = path & fileItem.FileName
		else
			fileItem.FileName = fileItem.FileName & " Discarded - File too big"
		end if
		 Next
	End Sub

This method checks if the file in the files collection is larger than the maximum file size and either discards it or saves it.
If discarded it sets the file name to give a message back to the calling routine

**************** end of changes to class file


in the upload page edit the SaveFiles() sub to read

    Set Upload = New FreeASPUpload
	
    Upload.MaxFileSize = 10000

    Upload.Save(uploadsDirVar)

It just adds the new line of Upload.MaxFileSize = 10000 where the number is the maximum files size (in bytes)
the example here is 10Kb


also if this is to run on a server where you do not know the physical path to the upload folder use;

  uploadsDirVar = server.mappath("\upload_folder_name")

to set it on the server rather than the hard coded path.

Thanks so much for your help.
However, I looked in the freeASPupload.asp file for the "private variable declaration block", and I can't find where that is.

And then you instructed to "in the upload page edit the SaveFiles() sub".
Where is the "upload page"?

Thanks again. I look forward to your clarification.

I looked in the freeASPupload.asp file for the "private variable declaration block", and I can't find where that is.

Where the variables are declared

Class FreeASPUpload
	Public UploadedFiles
	Public FormElements

	Private VarArrayBinRequest
	Private StreamRequest
	Private uploadedYet
	
	private m_lMaxFileSize

And then you instructed to "in the upload page edit the SaveFiles() sub".
Where is the "upload page"?

The page you posted the code for in the first post of this thread

http://www.webmaster-talk.com/asp-fo...tml#post497609

Thank you again for your assistance.

Could you please help me again with your instructions "in the upload page edit the SaveFiles() sub to read:

Set Upload = New FreeASPUpload
 
Upload.MaxFileSize = 10000

Upload.Save(uploadsDirVar)

I can't find SaveFiles().
Alsom when you say "edit", do you mean replace the code or add the code?
Lastly, when you state =10000, is that KB? Does it need a KB or MB?

Thanks again.

Your code from first post
Add the line in BLUE

<%@ Language=VBScript %>
<% 
option explicit 
Response.Expires = -1
Server.ScriptTimeout = 600
%>
<!-- #include file="aspupload.asp" -->
<%


' ****************************************************
' Change the value of the variable below to the pathname
' of a directory with write permissions, for example "C:\Inetpub\wwwroot"
  Dim uploadsDirVar
  uploadsDirVar = "d:\inetpub\webmailasp\database\tempUploads" 
' ****************************************************



function OutputForm()
%>
    <form name="frmSend" method="POST" enctype="multipart/form-data" action="uploadTester.asp" onSubmit="return onSubmitForm();">
	<B>File names:</B><br>
    File 1: <input name="attach1" type="file" size=35><br>
    File 2: <input name="attach2" type="file" size=35><br>
    File 3: <input name="attach3" type="file" size=35><br>
    File 4: <input name="attach4" type="file" size=35><br>
    <br> 
	<!-- These input elements are obviously optional and just included here for demonstration purposes -->
	<B>Additional fields (demo):</B><br>
	Enter a number: <input type="text" name="enter_a_number"><br>
    Checkbox values: <input type="checkbox" value="1" name="checkbox_values">-1 <input type="checkbox" value="2" name="checkbox_values">-2<br>
	<!-- End of additional elements -->
    <input style="margin-top:4" type=submit value="Upload">
    </form>
<%
end function

function TestEnvironment()
    Dim fso, fileName, testFile, streamTest
    TestEnvironment = ""
    Set fso = Server.CreateObject("Scripting.FileSystemObject")
    if not fso.FolderExists(uploadsDirVar) then
        TestEnvironment = "<B>Folder " & uploadsDirVar & " does not exist.</B><br>The value of your uploadsDirVar is incorrect. Open uploadTester.asp in an editor and change the value of uploadsDirVar to the pathname of a directory with write permissions."
        exit function
    end if
    fileName = uploadsDirVar & "\test.txt"
    on error resume next
    Set testFile = fso.CreateTextFile(fileName, true)
    If Err.Number<>0 then
        TestEnvironment = "<B>Folder " & uploadsDirVar & " does not have write permissions.</B><br>The value of your uploadsDirVar is incorrect. Open uploadTester.asp in an editor and change the value of uploadsDirVar to the pathname of a directory with write permissions."
        exit function
    end if
    Err.Clear
    testFile.Close
    fso.DeleteFile(fileName)
    If Err.Number<>0 then
        TestEnvironment = "<B>Folder " & uploadsDirVar & " does not have delete permissions</B>, although it does have write permissions.<br>Change the permissions for IUSR_<I>computername</I> on this folder."
        exit function
    end if
    Err.Clear
    Set streamTest = Server.CreateObject("ADODB.Stream")
    If Err.Number<>0 then
        TestEnvironment = "<B>The ADODB object <I>Stream</I> is not available in your server.</B><br>Check the Requirements page for information about upgrading your ADODB libraries."
        exit function
    end if
    Set streamTest = Nothing
end function

function SaveFiles
    Dim Upload, fileName, fileSize, ks, i, fileKey

Set Upload = New FreeASPUpload

    Upload.MaxFileSize = 10000

    Upload.Save(uploadsDirVar)

	' If something fails inside the script, but the exception is handled
	If Err.Number<>0 then Exit function

    SaveFiles = ""
    ks = Upload.UploadedFiles.keys
    if (UBound(ks) <> -1) then
        SaveFiles = "<B>Files uploaded:</B> "
        for each fileKey in Upload.UploadedFiles.keys
            SaveFiles = SaveFiles & Upload.UploadedFiles(fileKey).FileName & " (" & Upload.UploadedFiles(fileKey).Length & "B) "
        next
    else
        SaveFiles = "The file name specified in the upload form does not correspond to a valid file in the system."
    end if
	SaveFiles = SaveFiles & "<br>Enter a number = " & Upload.Form("enter_a_number") & "<br>"
	SaveFiles = SaveFiles & "Checkbox values = " & Upload.Form("checkbox_values") & "<br>"
end function
%>

<HTML>
<HEAD>
<TITLE>ASP Upload</TITLE>
<style>
BODY {background-color: white;font-family:arial; font-size:12}
</style>
<script>
function onSubmitForm() {
    var formDOMObj = document.frmSend;
    if (formDOMObj.attach1.value == "" && formDOMObj.attach2.value == "" && formDOMObj.attach3.value == "" && formDOMObj.attach4.value == "" )
        alert("Please press the browse button and pick a file.")
    else
        return true;
    return false;
}
</script>

</HEAD>

<BODY>

<br><br>
<div style="border-bottom: #A91905 2px solid;font-size:16">Upload files to your server</div>
<%
Dim diagnostics
if Request.ServerVariables("REQUEST_METHOD") <> "POST" then
    diagnostics = TestEnvironment()
    if diagnostics<>"" then
        response.write "<div style=""margin-left:20; margin-top:30; margin-right:30; margin-bottom:30;"">"
        response.write diagnostics
        response.write "<p>After you correct this problem, reload the page."
        response.write "</div>"
    else
        response.write "<div style=""margin-left:150"">"
        OutputForm()
        response.write "</div>"
    end if
else
    response.write "<div style=""margin-left:150"">"
    OutputForm()
    response.write SaveFiles()
    response.write "<br><br></div>"
end if

%>
<br><br>

</BODY>
</HTML>

It just adds the new line of Upload.MaxFileSize = 10000 where the number is the maximum files size (in bytes)
the example here is 10Kb

the file size is specified in bytes

Thank you so much again. I greatly appreciated your help.

Can this be set up so the file size shows in Kbytes instead of bytes?
Thanks again.

It could;

A extra bit of coding would be needed to the MaxFileSize Property to parse out a multiplier.

Give me 10 - 15 mins

new code for the class file

	public function  setMaxFileSize(ByVal Val, Mult)
		m_sByteMultiplier = Mult
		select case lcase(m_sByteMultiplier)
			case ""
				m_lMaxFileSize = Val
			case "k"
				m_lMaxFileSize = Val * 1024
			case "m"
				m_lMaxFileSize = Val * (1024 * 1024)
		end select
	end function

add this after the MaxFileSize() property definitions.

New variable to go with private m_lMaxFileSize

	private m_sByteMultiplier

and the Upload.MaxFileSize = 10000 needs changing to

	Upload.setMaxFileSize 0.5, "m"

for this the number is the filesize and the string ("m") is the multiplier

so
Upload.setMaxFileSize 0.5, "m" = 1/2 Megabyte
Upload.setMaxFileSize 5, "m" = 5 Megabyte
Upload.setMaxFileSize 10, "k" = 10 Kilobyte
Upload.setMaxFileSize 1000, "" = 1000 Bytes

Took a bit longer but I did make a brew in the middle of it

Thanks again so much for your help.

I looked around the class file, but I would be guessing where exactly to put this code.

Would it be like this (example A):

 
Private Sub Class_Terminate()
  public property let MaxFileSize(ByVal Val)
   m_lMaxFileSize = Val
  end property
  public property get MaxFileSize()
   MaxFileSize = m_lMaxFileSize
 end property
 
 public function  setMaxFileSize(ByVal Val, Mult)
        m_sByteMultiplier = Mult
        select case lcase(m_sByteMultiplier)
            case ""
                m_lMaxFileSize = Val
            case "k"
                m_lMaxFileSize = Val * 1024
            case "m"
                m_lMaxFileSize = Val * (1024 * 1024)
        end select
    end function

Or like this (example B):

 
Private Sub Class_Terminate()
  public property let MaxFileSize(ByVal Val)
   m_lMaxFileSize = Val
  end property
  public property get MaxFileSize()
   MaxFileSize = m_lMaxFileSize
 
 public function  setMaxFileSize(ByVal Val, Mult)
        m_sByteMultiplier = Mult
        select case lcase(m_sByteMultiplier)
            case ""
                m_lMaxFileSize = Val
            case "k"
                m_lMaxFileSize = Val * 1024
            case "m"
                m_lMaxFileSize = Val * (1024 * 1024)
        end select
    end function
 
 
 end property

Or neither?

And when you say this "private m_sByteMultiplier" "needs to go with" "private m_lMaxFileSize". What do you mean by "go with"?

And in the upload file, it should now look like this?:

    
Set Upload = New FreeASPUpload
Upload.setMaxFileSize 0.5, "m"
Upload.Save(uploadsDirVar)

Thanks again. I look forward to your reply.