Can anyone solve this problem, I have a If Then Else statement which does not seem to work.

Is there a problem with this code

<% 
If request("lang") = "1" Then 
Response.Write "Language 1" 
ElseIf request("lang") = "2" 
Response.Write "Language 2" 
Else 
response.redirect "index.asp?lang=1"
End If 
%>

As soon as I posted I saw the problem! Its now working.

For those who didn't see the problem (I did in that it's a missing "Then" on the third line), can you post your solution, please and thanks?

Also, in order to improve the efficiency of your code, you should write your request to a variable in the form Request.X ("lang") (where X is the type of request that it is...also speeds up your code). You'll get something like:

Dim Language
Language = Request.Form ("lang") ' Assuming it's a form
if Language = "1" then
...

Every time you use Request, you have to make a call to the server for it. It's also easier to read if it's a variable.

Or you could use a select ... case

with response
select case request.querystring("lang")
      case 1 
          .write "Language 1"
      case 2 
          .write "Language 2"
      case else
           .redirect index.asp?lang=1
end select
end with

Note assuming the use of querystring given the redirect URL

Why do people use select case statements? That always seemed like extra scaffolding code to me?

Same question for with blocks, I guess?

For me;

code readability on both counts

I've never been a fan of case statements either, particularly when I have multiple variables, items, etc. to compare. But to each their own, as long as it works.

I generally prefer if/then/else blocks over select case, but when you need to use one branching construct inside another, it's a lot more readable to use code like:

Select Case value
   Case External.StyleSheet:
      If UserAgent = MSIE_6 Then
         RenderStyleSheet "ie6.css"
      Else If UserAgent = MSIE_7 Then
         RenderStyleSheet "ie7.css"
      Else
         RenderStyleSheet "main.css"
      End If
   Case External.javascript:
      ...

You could do that with nested if statements, but it's easier to read the inner ones when they're wrapped in a different type of flow control.